Skip to content

gh-110437: Allow overriding VCRuntimeDLL with a semicolon separated list of DLLs to bundle #110470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 1 commit into from
Oct 9, 2023
+6 −1
Merged

gh-110437: Allow overriding VCRuntimeDLL with a semicolon separated list of DLLs to bundle #110470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-110437: Allow overriding VCRuntimeDLL with a semicolon separated l… 
…ist of DLLs to bundle
  • Loading branch information
@zooba
zooba committed Oct 6, 2023
commit 865a7fe4bfaf2d8e6ea5af26f05b4870f145e763
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Windows/2023-10-06-14-20-14.gh-issue-110437.xpYy9q.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Allows overriding the source of VC redistributables so that releases can be
guaranteed to never downgrade between updates.
5 changes: 4 additions & 1 deletion PCbuild/pyproject.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,10 @@ public override bool Execute() {
</Target>

<Target Name="FindVCRuntime" Returns="VCRuntimeDLL" DependsOnTargets="FindVCRedistDir">
<ItemGroup Condition="$(VCInstallDir) != ''">
<ItemGroup Condition="$(VCRuntimeDLL) != ''">
<VCRuntimeDLL Include="$(VCRuntimeDLL)" />
</ItemGroup>
<ItemGroup Condition="$(VCInstallDir) != '' and $(VCRuntimeDLL) == ''">
<VCRuntimeDLL Include="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*.dll" />
</ItemGroup>

Expand Down