Skip to content

gh-110300: Fix Refleaks in test_interpreters and test__xxinterpchannels #110318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 7 commits into from
Oct 4, 2023
Merged

gh-110300: Fix Refleaks in test_interpreters and test__xxinterpchannels #110318

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fbbebfd
Add a missing decref.
ericsnowcurrently Oct 3, 2023
8bfdf89
Add more missing decrefs.
ericsnowcurrently Oct 3, 2023
47a2bf6
Decref after get_module_from_owned_type().
ericsnowcurrently Oct 3, 2023
b291931
Stop leaking file descriptors.
ericsnowcurrently Oct 3, 2023
009aa91
Merge branch 'main' into fix-refleaks
ericsnowcurrently Oct 3, 2023
bb7e4e0
Temporarily drop the _register_end_types() call.
ericsnowcurrently Oct 3, 2023
2462033
Temporarily skip a failing test.
ericsnowcurrently Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Stop leaking file descriptors.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Oct 3, 2023
commit b2919311defe8e2ff29cac14e54d0d3bf49f0121
25 changes: 18 additions & 7 deletions Lib/test/test_interpreters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@ def run():

class TestBase(unittest.TestCase):

def pipe(self):
def ensure_closed(fd):
try:
os.close(fd)
except OSError:
pass
r, w = os.pipe()
self.addCleanup(lambda: ensure_closed(r))
self.addCleanup(lambda: ensure_closed(w))
return r, w

def tearDown(self):
clean_up_interpreters()

Expand Down Expand Up @@ -262,7 +273,7 @@ def test_subinterpreter(self):
self.assertFalse(interp.is_running())

def test_finished(self):
r, w = os.pipe()
r, w = self.pipe()
interp = interpreters.create()
interp.run(f"""if True:
import os
Expand Down Expand Up @@ -299,8 +310,8 @@ def test_bad_id(self):
interp.is_running()

def test_with_only_background_threads(self):
r_interp, w_interp = os.pipe()
r_thread, w_thread = os.pipe()
r_interp, w_interp = self.pipe()
r_thread, w_thread = self.pipe()

DONE = b'D'
FINISHED = b'F'
Expand Down Expand Up @@ -425,8 +436,8 @@ def test_still_running(self):
self.assertTrue(interp.is_running())

def test_subthreads_still_running(self):
r_interp, w_interp = os.pipe()
r_thread, w_thread = os.pipe()
r_interp, w_interp = self.pipe()
r_thread, w_thread = self.pipe()

FINISHED = b'F'

Expand Down Expand Up @@ -532,8 +543,8 @@ def test_bytes_for_script(self):
interp.run(b'print("spam")')

def test_with_background_threads_still_running(self):
r_interp, w_interp = os.pipe()
r_thread, w_thread = os.pipe()
r_interp, w_interp = self.pipe()
r_thread, w_thread = self.pipe()

RAN = b'R'
DONE = b'D'
Expand Down