Skip to content

gh-88402: Add new sysconfig variables on Windows (GH-110049) #110049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FFY00 merged 10 commits into from
Oct 4, 2023
Merged

gh-88402: Add new sysconfig variables on Windows (GH-110049) #110049

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
30814e4
gh-88402: Add new sysconfig variables on Windows
colesbury Sep 28, 2023
3f2a744
Update 2023-09-28-12-32-57.gh-issue-88402.hoa3Gx.rst
colesbury Oct 2, 2023
0ce92b2
Compute some sysconfig variables in _winapi
colesbury Oct 4, 2023
aa396e5
Move Python/importdl.h to Include/internal/pycore_importdl.h
colesbury Oct 4, 2023
89f891c
Add _sysconfig module
colesbury Oct 4, 2023
14d201c
Update Modules/_sysconfig.c
colesbury Oct 4, 2023
34fe412
Fix "Py_NOGIL" sysconfig variable.
colesbury Oct 4, 2023
db30ede
Compute PYD_TAGGED_SUFFIX and PYD_SOABI in pycore_importdl.h
colesbury Oct 4, 2023
f0fb235
regen clinic
colesbury Oct 4, 2023
0a84d76
Fix sysconfig test on POSIX systems.
colesbury Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix "Py_NOGIL" sysconfig variable. 
It should be zero or one and always defined.
  • Loading branch information
@colesbury
colesbury committed Oct 4, 2023
commit 34fe412468a1b5be2adbf14f78856c117880a46b
10 changes: 8 additions & 2 deletions Modules/_sysconfig.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include "Python.h"

#include "pycore_importdl.h" // _PyImport_DynLoadFiletab
#include "pycore_long.h" // _PyLong_GetZero, _PyLong_GetOne


/*[clinic input]
Expand Down Expand Up @@ -54,12 +55,17 @@ _sysconfig_config_vars_impl(PyObject *module)
return NULL;
}
#endif

#ifdef Py_NOGIL
if (PyDict_SetItem(config, "Py_NOGIL", _PyLong_GetOne()) < 0) {
PyObject *py_nogil = _PyLong_GetOne();
#else
PyObject *py_nogil = _PyLong_GetZero();
#endif
if (PyDict_SetItemString(config, "Py_NOGIL", py_nogil) < 0) {
Py_DECREF(config);
return NULL;
}
#endif

return config;
}

Expand Down