Skip to content

gh-102837: Increase test coverage for the math module #110000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skirpichev wants to merge 28 commits into from
Closed

gh-102837: Increase test coverage for the math module #110000

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a1d2c1a
gh-102837: Increase test coverage for the math module
skirpichev Sep 18, 2023
03e8ead
Improve math_2() comment (mention real use-cases for math_2)
skirpichev Sep 18, 2023
26489bb
* trunc: drop _PyType_IsReady() check (L2071) like floor/ceil, L2079
skirpichev Sep 18, 2023
128c81d
* log: L2265
skirpichev Sep 18, 2023
ead9eee
* loghelper: drop inaccessible cases L2234, L2235, L2241. Here arg i…
skirpichev Sep 18, 2023
3a80c78
* dist: L2575, L2577
skirpichev Sep 18, 2023
8b3bb52
* hypot: L2630
skirpichev Sep 18, 2023
4e25c35
* sumprod: L2742, L2752, L2772, L2775, L2779, L2783
skirpichev Sep 19, 2023
7956447
Fix typo in sumprod()
skirpichev Sep 19, 2023
052d7de
* sumprod: L2829, L2833, L2836
skirpichev Sep 19, 2023
b431805
* pow: L2979, L2980
skirpichev Sep 19, 2023
a046568
* prod: L3292, L3306, L3316-3328
skirpichev Sep 19, 2023
d7675d7
Merge branch 'main' into math-cov
skirpichev Sep 28, 2023
96f99cd
Merge branch 'main' into math-cov
skirpichev Oct 6, 2023
3df127e
More efficient (for finite x) handling of special cases in math.modf
skirpichev Oct 6, 2023
5e6d59f
Change error tests in loghelper() to more lightweight versions (x == …
skirpichev Oct 6, 2023
3e8d96f
Explicit tests for non-float objects (amend a1d2c1afbf)
skirpichev Oct 15, 2023
35db224
Amend 8b3bb52420 (use math.sqrt(2) instead)
skirpichev Oct 15, 2023
6844b19
Amend 052d7de86
skirpichev Oct 29, 2023
6037d84
Merge branch 'main' into math-cov
skirpichev Nov 3, 2023
d2c5170
Merge branch 'main' into math-cov
encukou Nov 13, 2023
833d852
Merge branch 'main' into math-cov
serhiy-storchaka Dec 1, 2023
5768395
Merge branch 'main' into math-cov
skirpichev Dec 9, 2023
ad84c4a
Revert PyErr_ExceptionMatches
skirpichev Dec 9, 2023
21bc1b8
Merge branch 'main' into math-cov
skirpichev Apr 2, 2024
d488a1d
Merge branch 'main' into math-cov
skirpichev May 31, 2024
dce58b3
Merge branch 'main' into math-cov
skirpichev Jul 24, 2024
d313423
Merge branch 'main' into math-cov
skirpichev Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
* sumprod: L2829, L2833, L2836
  • Loading branch information
@skirpichev
skirpichev committed Sep 28, 2023
commit 052d7de86743e260a50cc691b5d45e33bec6eab7
6 changes: 6 additions & 0 deletions Lib/test/test_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,6 +1269,9 @@ def testSumProd(self):
self.assertEqual(sumprod(iter([10, 20, 30]), (1, 2, 3)), 140)
self.assertEqual(sumprod([1.5, 2.5], [3.5, 4.5]), 16.5)
self.assertEqual(sumprod([], []), 0)
self.assertEqual(sumprod([-1], [1.]), -1)
self.assertEqual(sumprod([1.], [-1]), -1)
self.assertEqual(sumprod([True], [1.0]), 1)

# Type preservation and coercion
for v in [
Expand All @@ -1294,6 +1297,7 @@ def testSumProd(self):
self.assertRaises(TypeError, sumprod, [], [], []) # Three args
self.assertRaises(TypeError, sumprod, None, [10]) # Non-iterable
self.assertRaises(TypeError, sumprod, [10], None) # Non-iterable
self.assertRaises(TypeError, sumprod, ['x'], [1.0])

# Uneven lengths
self.assertRaises(ValueError, sumprod, [10, 20], [30])
Expand All @@ -1304,6 +1308,8 @@ def testSumProd(self):
self.assertEqual(sumprod([1], [10**20]), 10**20)
self.assertEqual(sumprod([10**10], [10**10]), 10**20)
self.assertEqual(sumprod([10**7]*10**5, [10**7]*10**5), 10**19)
self.assertRaises(OverflowError, sumprod, [10**1000], [1.0])
self.assertRaises(OverflowError, sumprod, [1.0], [10**1000])

# Error in iterator
def raise_after(n):
Expand Down