Skip to content

GH-109408: Move the C file whitespace check from patchcheck to pre-commit #109890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 11 commits into from
Oct 10, 2023
Merged

GH-109408: Move the C file whitespace check from patchcheck to pre-commit #109890

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f7d8e99
Move the C file whitespace check to pre-commit
AA-Turner Sep 26, 2023
25688d9
unused variable
AA-Turner Sep 26, 2023
6e9040c
Exclude vendored code
AA-Turner Sep 26, 2023
0e20e9f
Fix tabs when run locally
AA-Turner Sep 26, 2023
b44f4c2
Exit with the right code
AA-Turner Sep 26, 2023
d4d31ff
zlib is no more
AA-Turner Sep 26, 2023
b70cece
More concise comment
hugovk Oct 10, 2023
986f2a3
Merge branch 'main' into patchcheck/c-file-whitespace
AA-Turner Oct 10, 2023
b15ef27
Remove the now-redundant --ci option
AA-Turner Oct 10, 2023
556978b
Remove unused imports, variables, and functions
AA-Turner Oct 10, 2023
6891bdb
Verbose regular expression
AA-Turner Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused imports, variables, and functions
  • Loading branch information
@AA-Turner
AA-Turner committed Oct 10, 2023
commit 556978b8de51aa9a81afcab09a0717f482260ff8
19 changes: 0 additions & 19 deletions Tools/patchcheck/patchcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
#!/usr/bin/env python3
"""Check proposed changes for common issues."""
import re
import sys
import shutil
import os.path
import subprocess
import sysconfig
Expand Down Expand Up @@ -146,23 +144,6 @@ def changed_files(base_branch=None):
return list(map(os.path.normpath, filenames))


def report_modified_files(file_paths):
count = len(file_paths)
if count == 0:
return n_files_str(count)
else:
lines = [f"{n_files_str(count)}:"]
for path in file_paths:
lines.append(f" {path}")
return "\n".join(lines)


#: Python files that have tabs by design:
_PYTHON_FILES_WITH_TABS = frozenset({
'Tools/c-analyzer/cpython/_parser.py',
})


@status("Docs modified", modal=True)
def docs_modified(file_paths):
"""Report if any file in the Doc directory has been changed."""
Expand Down