Skip to content

gh-76785: Use Pending Calls When Releasing Cross-Interpreter Data #109556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 11 commits into from
Sep 19, 2023
Merged

gh-76785: Use Pending Calls When Releasing Cross-Interpreter Data #109556

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fb807e3
Use the raw allocator.
ericsnowcurrently Aug 30, 2023
e96eefc
Drop the unnecessary arg to _release_xid_data().
ericsnowcurrently Sep 9, 2023
53e1029
Pass a flag to _release_xid_data().
ericsnowcurrently Sep 7, 2023
8ef9b95
Add the _Py_pending_call_func typedef.
ericsnowcurrently Sep 7, 2023
daa7f32
Do not bother freeing the data if not set.
ericsnowcurrently Sep 7, 2023
5d94456
Use pending calls when releasing cross-interpreter data.
ericsnowcurrently Sep 7, 2023
c610c41
Use _release_xidata_pending() indirectly.
ericsnowcurrently Sep 7, 2023
1d12503
Optionally free the provided XID after releasing.
ericsnowcurrently Sep 7, 2023
0b5a84a
Add _PyCrossInterpreterData_ReleaseAndRawFree().
ericsnowcurrently Sep 7, 2023
ac9d0db
Fix _release_xid_data().
ericsnowcurrently Sep 19, 2023
f38f44b
Do not directly free the XI data in _channelitem_clear().
ericsnowcurrently Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use pending calls when releasing cross-interpreter data.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Sep 9, 2023
commit 5d9445658c2647f25dfd9acee7170434720b1a55
38 changes: 11 additions & 27 deletions Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2417,32 +2417,11 @@ _PyCrossInterpreterData_NewObject(_PyCrossInterpreterData *data)
return data->new_object(data);
}

typedef void (*releasefunc)(PyInterpreterState *, void *);

static void
_call_in_interpreter(PyInterpreterState *interp, releasefunc func, void *arg)
static int
_release_xidata_pending(void *data)
{
/* We would use Py_AddPendingCall() if it weren't specific to the
* main interpreter (see bpo-33608). In the meantime we take a
* naive approach.
*/
_PyRuntimeState *runtime = interp->runtime;
PyThreadState *save_tstate = NULL;
if (interp != current_fast_get(runtime)->interp) {
// XXX Using the "head" thread isn't strictly correct.
PyThreadState *tstate = PyInterpreterState_ThreadHead(interp);
// XXX Possible GILState issues?
save_tstate = _PyThreadState_Swap(runtime, tstate);
}

// XXX Once the GIL is per-interpreter, this should be called with the
// calling interpreter's GIL released and the target interpreter's held.
func(interp, arg);

// Switch back.
if (save_tstate != NULL) {
_PyThreadState_Swap(runtime, save_tstate);
}
_xidata_clear((_PyCrossInterpreterData *)data);
return 0;
}

int
Expand All @@ -2465,8 +2444,13 @@ _PyCrossInterpreterData_Release(_PyCrossInterpreterData *data)
}

// "Release" the data and/or the object.
_call_in_interpreter(interp,
(releasefunc)_PyCrossInterpreterData_Clear, data);
if (interp == current_fast_get(interp->runtime)->interp) {
_xidata_clear(data);
}
else {
// XXX Emit a warning if this fails?
_PyEval_AddPendingCall(interp, _release_xidata_pending, data, 0);
}
return 0;
}

Expand Down