Skip to content

gh-107219: Fix concurrent.futures terminate_broken() #109244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Sep 11, 2023
+27 −0
Merged

gh-107219: Fix concurrent.futures terminate_broken() #109244

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c82464
gh-107219: Fix concurrent.futures terminate_broken()
vstinner Sep 10, 2023
069fbfa
Remove PipeConnection.__init__()
vstinner Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove PipeConnection.__init__() 
Address Serhiy's review.
  • Loading branch information
@vstinner
vstinner committed Sep 11, 2023
commit 069fbfa35488828d4e23eb4a39c17b7b38bd6a39
5 changes: 1 addition & 4 deletions Lib/multiprocessing/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,7 @@ class PipeConnection(_ConnectionBase):
with FILE_FLAG_OVERLAPPED.
"""
_got_empty_message = False

def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self._send_ov = None
_send_ov = None

def _close(self, _CloseHandle=_winapi.CloseHandle):
ov = self._send_ov
Expand Down