Move __missing__ after __delitem__ in Data model#10923
Merged
Merged
Conversation
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
I would move also .. index:: object: slice before .. note::.
serhiy-storchaka
approved these changes
Dec 5, 2018
Contributor
Author
|
@serhiy-storchaka I agree with your suggestion. |
Contributor
|
Thanks @andresdelfino for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2018
(cherry picked from commit 1ce853f) Co-authored-by: Andre Delfino <adelfino@gmail.com>
|
GH-10938 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2018
(cherry picked from commit 1ce853f) Co-authored-by: Andre Delfino <adelfino@gmail.com>
|
GH-10939 is a backport of this pull request to the 3.6 branch. |
Contributor
|
Sorry, @andresdelfino and @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Dec 5, 2018
(cherry picked from commit 1ce853f) Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Dec 5, 2018
(cherry picked from commit 1ce853f) Co-authored-by: Andre Delfino <adelfino@gmail.com>
|
GH-10944 is a backport of this pull request to the 2.7 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc says "Slicing is done exclusively with the following three methods", and it was correct until b67f6e2 . Since then, it documents __missing__ between __getitem__ and __setitem__.