Skip to content

GH-108614: Add RESUME_CHECK instruction #108630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 9 commits into from
Sep 7, 2023
Merged

GH-108614: Add RESUME_CHECK instruction #108630

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9a097f4
Add RESUME_QUICK instruction to minimize overhead of checking for ins…
markshannon Aug 26, 2023
0b201d0
Rename RESUME_QUICK to RESUME_CHECK
markshannon Aug 27, 2023
d35139b
Merge branch 'main' into quick-resume
markshannon Aug 27, 2023
a8c5ac8
Update test_dis
markshannon Aug 27, 2023
c5f4615
Remove debug print
markshannon Aug 27, 2023
9ec38ae
Avoid counter reaching zero if Py_EMSCRIPTEN_SIGNAL_HANDLING is false
markshannon Aug 27, 2023
cdd74a4
Merge branch 'main' into quick-resume
markshannon Aug 28, 2023
cb92e64
Fix news entry
markshannon Sep 4, 2023
214530d
Make sure to decrement emscripten_signal_clock.
markshannon Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid counter reaching zero if Py_EMSCRIPTEN_SIGNAL_HANDLING is false
  • Loading branch information
@markshannon
markshannon committed Aug 27, 2023
commit 9ec38ae0d78f0dbc36c50ffd1ab4caa60b2c5958
2 changes: 1 addition & 1 deletion Python/emscripten_signal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ _Py_CheckEmscriptenSignalsPeriodically(void)
emscripten_signal_clock = PY_EMSCRIPTEN_SIGNAL_INTERVAL;
_Py_CheckEmscriptenSignals();
}
else {
else if (Py_EMSCRIPTEN_SIGNAL_HANDLING) {
emscripten_signal_clock--;
}
}