Skip to content

bpo-30047: Fix typos in Doc/library/select.rst#1086

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
osamu0329nakamura:patch-1
Apr 12, 2017
Merged

bpo-30047: Fix typos in Doc/library/select.rst#1086
serhiy-storchaka merged 1 commit into
python:masterfrom
osamu0329nakamura:patch-1

Conversation

@osamu0329nakamura
Copy link
Copy Markdown
Contributor

In 18.3.2. Edge and Level Trigger Polling (epoll) Objects,
there is duplicated 'on' in description of EPOLLEXCLUSIVE.

   Wake only ... objects polling on on a fd.
                                 ^^^^^

In 18.3.2. Edge and Level Trigger Polling (epoll) Objects,
there is duplicated 'on' in description of `EPOLLEXCLUSIVE`.
```
   Wake only ... objects polling on on a fd.
                                 ^^^^^
```
@mention-bot
Copy link
Copy Markdown

@osamu0329nakamura, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @birkenfeld and @jcea to be potential reviewers.

Comment thread Doc/library/select.rst
| | associated fd has an event. The default (if |
| | this flag is not set) is to wake all epoll |
| | objects polling on on a fd. |
| | objects polling on a fd. |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "on on" correction is fine, but it looks like trailing whitespace was added.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a table. All correct.

Comment thread Doc/library/select.rst
| | associated fd has an event. The default (if |
| | this flag is not set) is to wake all epoll |
| | objects polling on on a fd. |
| | objects polling on a fd. |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a table. All correct.

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir needs backport to 3.6 labels Apr 12, 2017
@serhiy-storchaka serhiy-storchaka merged commit 3e0f1fc into python:master Apr 12, 2017
@serhiy-storchaka
Copy link
Copy Markdown
Member

Thanks @osamu0329nakamura. Could you backport this change to 3.6?

@Mariatta
Copy link
Copy Markdown
Member

I will do the backport, since I want to experiment with recent changes to cherry_picker.py :)
Thanks.

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Apr 13, 2017
Mariatta added a commit that referenced this pull request Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants