Skip to content

gh-108520: Fix bad fork detection in nested multiprocessing use case #108568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 9 commits into from
Aug 30, 2023
Merged

gh-108520: Fix bad fork detection in nested multiprocessing use case #108568

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ec4e7e0
Support nesting and add test
albanD Aug 28, 2023
1b62ab0
Cleanup test code
albanD Aug 30, 2023
9212635
Properly set is_fork_ctx in set_state
albanD Aug 30, 2023
c0ee443
Rename is_fork_ctx to _is_fork_ctx
albanD Aug 30, 2023
19225fc
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 30, 2023
61d402d
Blurb nits
pitrou Aug 30, 2023
6eae967
Improve co
pitrou Aug 30, 2023
11e6b02
Merge branch 'main' into fix-issue-108520
pitrou Aug 30, 2023
051f326
Update comment
pitrou Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup test code
  • Loading branch information
@albanD
albanD committed Aug 30, 2023
commit 1b62ab02d61e75a7bbcda20e21ba0d36007fb09a
25 changes: 14 additions & 11 deletions Lib/test/_test_multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5342,16 +5342,6 @@ def test_ignore_listener(self):
finally:
conn.close()

# Utility functions used as target for spawn Process
def put_one_in_queue(queue):
queue.put(1)

def put_two_and_nest_once(queue):
queue.put(2)
process = multiprocessing.Process(target=put_one_in_queue, args=(queue,))
process.start()
process.join()

class TestStartMethod(unittest.TestCase):
@classmethod
def _check_context(cls, conn):
Expand Down Expand Up @@ -5453,10 +5443,23 @@ def test_mixed_startmethod(self):
p.start()
p.join()

@classmethod
def _put_one_in_queue(cls, queue):
queue.put(1)

@classmethod
def _put_two_and_nest_once(cls, queue):
queue.put(2)
process = multiprocessing.Process(target=cls._put_one_in_queue, args=(queue,))
process.start()
process.join()

def test_nested_startmethod(self):
Comment thread
albanD marked this conversation as resolved.
# gh-108520: Regression test to ensure that child process can send its
# arguments to another process
queue = multiprocessing.Queue()

process = multiprocessing.Process(target=put_two_and_nest_once, args=(queue,))
process = multiprocessing.Process(target=self._put_two_and_nest_once, args=(queue,))
process.start()
process.join()

Expand Down