Skip to content

get_gmtoff() now returns time_t#10838

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:get_gmtoff_time_t
Nov 30, 2018
Merged

get_gmtoff() now returns time_t#10838
vstinner merged 1 commit into
python:masterfrom
vstinner:get_gmtoff_time_t

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Nov 30, 2018 •
edited
Loading

get_gmtoff() now returns time_t instead of int to fix the following
Visual Studio warning:

Modules\timemodule.c(1183): warning C4244: 'return':
conversion from 'time_t' to 'int', possible loss of data

@vstinner
get_gmtoff() now returns time_t
ad304dd 
get_gmtoff() now returns time_t instead of int to fix the following
Visual Studio warning:

    Modules\timemodule.c(1183): warning C4244: 'return':
    conversion from 'time_t' to 'int', possible loss of data
@vstinner vstinner merged commit 503ce5c into python:master Nov 30, 2018
@vstinner vstinner deleted the get_gmtoff_time_t branch November 30, 2018 23:39
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Nov 30, 2018

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Nov 30, 2018

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Nov 30, 2018

Sorry, @vstinner, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 503ce5c482cb267b0770bc46c315d5cf822bdca9 3.6

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Nov 30, 2018

Sorry, @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 503ce5c482cb267b0770bc46c315d5cf822bdca9 3.7

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 30, 2018

GH-10839 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 30, 2018

GH-10840 is a backport of this pull request to the 3.6 branch.

vstinner added a commit that referenced this pull request Dec 1, 2018
@vstinner
get_gmtoff() now returns time_t (GH-10838) (GH-10840)
6c3f272 
get_gmtoff() now returns time_t instead of int to fix the following
Visual Studio warning:

    Modules\timemodule.c(1183): warning C4244: 'return':
    conversion from 'time_t' to 'int', possible loss of data

(cherry picked from commit 503ce5c)
vstinner added a commit that referenced this pull request Dec 1, 2018
@vstinner
get_gmtoff() now returns time_t (GH-10838) (GH-10839)
38c06d9 
get_gmtoff() now returns time_t instead of int to fix the following
Visual Studio warning:

    Modules\timemodule.c(1183): warning C4244: 'return':
    conversion from 'time_t' to 'int', possible loss of data

(cherry picked from commit 503ce5c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vstinner vstinner

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni