Skip to content

gh-91051: fix type watcher test to be robust to existing watcher #107989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carljm merged 2 commits into from
Aug 16, 2023
+4 −6
Merged

gh-91051: fix type watcher test to be robust to existing watcher #107989

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c38bd5
gh-91051: fix type watcher test to be robust to existing watcher
carljm Aug 16, 2023
b1b0193
avoid while True
carljm Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
avoid while True
  • Loading branch information
@carljm
carljm committed Aug 16, 2023
commit b1b0193e92b78440843df17ccbc79d3347f6e22d
2 changes: 1 addition & 1 deletion Lib/test/test_capi/test_watchers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ def test_clear_unassigned_watcher_id(self):
def test_no_more_ids_available(self):
with self.assertRaisesRegex(RuntimeError, r"no more type watcher IDs"):
with ExitStack() as stack:
while True:
for _ in range(self.TYPE_MAX_WATCHERS + 1):
stack.enter_context(self.watcher())


Expand Down