Skip to content

gh-107704: Argument Clinic: add support for deprecating keyword use of parameters #107984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 15 commits into from
Aug 19, 2023
Merged

gh-107704: Argument Clinic: add support for deprecating keyword use of parameters #107984

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
059cd6a
gh-107704: Argument Clinic: add support for deprecating keyword use o…
serhiy-storchaka Aug 8, 2023
b4b9f3c
Silence check-c-globals.py.
serhiy-storchaka Aug 15, 2023
d5e0064
Update the documentation.
serhiy-storchaka Aug 15, 2023
b1300c7
Make constructor's arguments optional, it produces more interesting o…
serhiy-storchaka Aug 15, 2023
ad36c15
Address review comments.
serhiy-storchaka Aug 16, 2023
e271834
Add a test for `* [from ...]` with not inlined parsing code
serhiy-storchaka Aug 17, 2023
e603de7
Consistently use simple function name in error messages.
serhiy-storchaka Aug 17, 2023
3b6f6c4
Apply suggestions from code review
serhiy-storchaka Aug 18, 2023
94d9b34
Merge branch 'main' into clinic-deprecated-keyword
serhiy-storchaka Aug 18, 2023
158c5e3
Rename _testclinic_depr_star.c.h -> _testclinic_depr.c.h
serhiy-storchaka Aug 18, 2023
5c92d36
More efficient checks in case of inlined parsing code.
serhiy-storchaka Aug 18, 2023
6607137
Fix non-inlined parsing in __init__ and __new__.
serhiy-storchaka Aug 18, 2023
9fee851
Fix a case of: inlined parsing + no keyword args + omit some some opt…
serhiy-storchaka Aug 18, 2023
38c9560
Update Tools/c-analyzer/cpython/globals-to-fix.tsv.
serhiy-storchaka Aug 19, 2023
71ea31c
Merge branch 'main' into clinic-deprecated-keyword
serhiy-storchaka Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename _testclinic_depr_star.c.h -> _testclinic_depr.c.h
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Aug 18, 2023
commit 158c5e3d162c3342178de88ae6f4fae679040305
6 changes: 3 additions & 3 deletions Modules/_testclinic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,14 +1195,14 @@ clone_with_conv_f2_impl(PyObject *module, custom_t path)

/*[clinic input]
output push
destination deprstar new file '{dirname}/clinic/_testclinic_depr_star.c.h'
destination deprstar new file '{dirname}/clinic/_testclinic_depr.c.h'
output everything deprstar
#output methoddef_ifndef buffer 1
output docstring_prototype suppress
output parser_prototype suppress
output impl_definition block
[clinic start generated code]*/
/*[clinic end generated code: output=da39a3ee5e6b4b0d input=f88f37038e00fb0a]*/
/*[clinic end generated code: output=da39a3ee5e6b4b0d input=32116eac48a42d34]*/


// Mock Python version 3.8
Expand All @@ -1211,7 +1211,7 @@ output impl_definition block
#define PY_VERSION_HEX 0x03080000


#include "clinic/_testclinic_depr_star.c.h"
#include "clinic/_testclinic_depr.c.h"


/*[clinic input]
Expand Down
0 Modules/clinic/_testclinic_depr_star.c.h → Modules/clinic/_testclinic_depr.c.h
View file
Open in desktop
File renamed without changes.