Skip to content

GH-107674: Avoid allocating boxed ints for sys.settrace line events #107780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 6 commits into from
Aug 10, 2023
+39 −6
Merged

GH-107674: Avoid allocating boxed ints for sys.settrace line events #107780

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0ccd3bb
Use PyLong_FromLong instead of PyLong_FromSsize_t in instrumentation.c.
markshannon Aug 5, 2023
83ffca9
Avoid boxing and unboxing line number for sys.settrace
markshannon Aug 5, 2023
de050f2
Add news
markshannon Aug 5, 2023
9077b17
Address review comments
markshannon Aug 9, 2023
7460a99
Clarify comments
markshannon Aug 9, 2023
6b4bafb
Fix editing
markshannon Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix editing
  • Loading branch information
@markshannon
markshannon committed Aug 9, 2023
commit 6b4bafbf422e3ab34d947603b9370a489e0ae76c
2 changes: 1 addition & 1 deletion Python/instrumentation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,7 +1158,7 @@ _Py_call_instrumentation_line(PyThreadState *tstate, _PyInterpreterFrame* frame,
PyFrameObject *frame_obj = _PyFrame_GetFrameObject(frame);
if (frame_obj == NULL) {
return -1;
// }
}
if (frame_obj->f_trace_lines) {
/* Need to set tracing and what_event as if using
* the instrumentation call. */
Expand Down