Skip to content

gh-106368: Increase test coverage for Argument Clinic #107514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 6 commits into from
Aug 2, 2023
Merged

gh-106368: Increase test coverage for Argument Clinic #107514

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f1a9af
gh-106368: Increase test coverage for Argument Clinic
erlend-aasland Jul 31, 2023
2acaed4
Pull in main
erlend-aasland Aug 2, 2023
7c06c31
Fix clinic.test.c
erlend-aasland Aug 2, 2023
00a9557
Parametrise version directive tests
erlend-aasland Aug 2, 2023
15140d0
Pull in main
erlend-aasland Aug 2, 2023
0618a20
Partially revert parametrised tests
erlend-aasland Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Partially revert parametrised tests
  • Loading branch information
@erlend-aasland
erlend-aasland committed Aug 2, 2023
commit 0618a202bbd422fac73cc4cbcc04dbf98ab57284
36 changes: 12 additions & 24 deletions Lib/test/test_clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,30 +369,18 @@ def test_version_directive(self):
self.clinic.parse(block)

def test_version_directive_insufficient_version(self):
dataset = (
# (clinic version, required version)
('2', '3'),
('1.4', '1.5'),
('1.1a0', '1.1'),
('1.1b0', '1.1'),
('1.2b1', '1.2b2'),
('1.2a7', '1.2b1'),
)
for clinic_version, required_version in dataset:
with self.subTest(clinic_version=clinic_version,
required_version=required_version):
with self._clinic_version(clinic_version):
err = (
"Insufficient Clinic version!\n"
f" Version: {clinic_version}\n"
f" Required: {required_version}"
)
out = self.expect_failure(f"""
/*[clinic input]
version {required_version}
[clinic start generated code]*/
""")
self.assertIn(err, out)
with self._clinic_version('4'):
err = (
"Insufficient Clinic version!\n"
" Version: 4\n"
" Required: 5"
)
out = self.expect_failure("""
/*[clinic input]
version 5
[clinic start generated code]*/
""")
self.assertIn(err, out)

def test_version_directive_illegal_char(self):
err = "Illegal character 'v' in version string 'v5'"
Expand Down