Skip to content

gh-77377: Ensure multiprocessing SemLock is valid for spawn-based Process before serializing it #107275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 5 commits into from
Aug 23, 2023
Merged

gh-77377: Ensure multiprocessing SemLock is valid for spawn-based Process before serializing it #107275

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9aeedf
Ensure multiprocessing lock is valid for spawn Process before seriali…
albanD Jul 25, 2023
df69347
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 25, 2023
152800c
Improve test to run on macos and cover forkserver
albanD Aug 23, 2023
29d37e1
Fix typos and wording
pitrou Aug 23, 2023
e5f4e32
lint
albanD Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lint
  • Loading branch information
@albanD
albanD committed Aug 23, 2023
commit e5f4e32479289998db3ae6831b08e826318e2da8
14 changes: 9 additions & 5 deletions Lib/test/_test_multiprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5421,21 +5421,25 @@ def test_preload_resources(self):
print(err)
self.fail("failed spawning forkserver or grandchild")

@unittest.skipIf(sys.platform == "win32", "Only Spawn on windows so no risk of mixing")
@only_run_in_spawn_testsuite("avoids redundant testing since we ignore the global context.")
@unittest.skipIf(sys.platform == "win32",
"Only Spawn on windows so no risk of mixing")
@only_run_in_spawn_testsuite("avoids redundant testing.")
def test_mixed_startmethod(self):
# Fork-based locks cannot be used with spawned process
for process_method in ["spawn", "forkserver"]:
queue = multiprocessing.get_context("fork").Queue()
p = multiprocessing.get_context(process_method).Process(target=close_queue, args=(queue,))
with self.assertRaisesRegex(RuntimeError, "A SemLock created in a fork"):
process_ctx = multiprocessing.get_context(process_method)
p = process_ctx.Process(target=close_queue, args=(queue,))
err_msg = "A SemLock created in a fork"
with self.assertRaisesRegex(RuntimeError, err_msg):
p.start()

# non-fork-based locks can be used with all other start methods
for queue_method in ["spawn", "forkserver"]:
for process_method in multiprocessing.get_all_start_methods():
queue = multiprocessing.get_context(queue_method).Queue()
p = multiprocessing.get_context(process_method).Process(target=close_queue, args=(queue,))
process_ctx = multiprocessing.get_context(process_method)
p = process_ctx.Process(target=close_queue, args=(queue,))
p.start()
p.join()

Expand Down