Add 2 missing commas#10698
Conversation
Fixed the typing docs by adding 2 missing commas.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
I've signed the PSF contributor agreement (CLA), but it indicates here that I have not done that. Strange. |
|
This is English orthography, nothing personal. 😉 |
rhettinger
left a comment
There was a problem hiding this comment.
I think only the first of these two is correct.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I've reverted my second change where I added a comma and realized that according to English orthographical rules it must not apply. The comma in the sentence "At runtime," is, however, necessary. Commas are not randomly placed by the writer according to "it feels right to me" but there are strict orthographical rules where each comma is placed in a sentence.
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @rhettinger: please review the changes made to this pull request. |
Fixed the typing docs by adding 2 missing commas.