Skip to content

gh-104050: Argument Clinic: Annotate CLanguage.render_option_group_parsing() #106929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 4 commits into from
Jul 20, 2023
Merged

gh-104050: Argument Clinic: Annotate CLanguage.render_option_group_parsing() #106929

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0d3d9d
gh-104050: Argument Clinic: Annotate CLanguage.render_option_group_pa…
erlend-aasland Jul 20, 2023
a13d26b
Apply suggestions from code review
erlend-aasland Jul 20, 2023
4fa647e
Apply suggestions from code review
erlend-aasland Jul 20, 2023
5fe6c3f
🤦
erlend-aasland Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Rip out ParamIter
  • Loading branch information
@erlend-aasland
erlend-aasland committed Jul 20, 2023
commit 4fa647ef6c3d95e378d1edbfa52d02e895b0fbac
11 changes: 5 additions & 6 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,12 +530,11 @@ class PythonLanguage(Language):
checksum_line = "#/*[{dsl_name} end generated code: {arguments}]*/"


ParamIter = Iterable["Parameter"]
ParamTuple = tuple["Parameter", ...]


def permute_left_option_groups(
l: Sequence[ParamIter]
l: Sequence[Iterable[Parameter]]
) -> Iterator[ParamTuple]:
"""
Given [(1,), (2,), (3,)], should yield:
Expand All @@ -552,7 +551,7 @@ def permute_left_option_groups(


def permute_right_option_groups(
l: Sequence[ParamIter]
l: Sequence[Iterable[Parameter]]
) -> Iterator[ParamTuple]:
"""
Given [(1,), (2,), (3,)], should yield:
Expand All @@ -569,9 +568,9 @@ def permute_right_option_groups(


def permute_optional_groups(
left: Sequence[ParamIter],
required: ParamIter,
right: Sequence[ParamIter]
left: Sequence[Iterable[Parameter]],
required: Iterable[Parameter],
right: Sequence[Iterable[Parameter]]
) -> tuple[ParamTuple, ...]:
"""
Generator function that computes the set of acceptable
Expand Down