Skip to content

gh-64595: Fix regression in file write logic in Argument Clinic #106449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 2 commits into from
Jul 5, 2023
Merged

gh-64595: Fix regression in file write logic in Argument Clinic #106449

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f5936a
gh-64595: Fix regression in file write logic in Argument Clinic
erlend-aasland Jul 5, 2023
2685d74
Also revert tests
erlend-aasland Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Also revert tests
  • Loading branch information
@erlend-aasland
erlend-aasland committed Jul 5, 2023
commit 2685d74bf15f88460b766dedd76d20293315bd4a
7 changes: 3 additions & 4 deletions Lib/test/test_clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,8 @@ def test_eol(self):
# the last line of the block got corrupted.
c = clinic.Clinic(clinic.CLanguage(None), filename="file")
raw = "/*[clinic]\nfoo\n[clinic]*/"
cooked, _ = c.parse(raw)
lines = cooked.splitlines()
end_line = lines[2].rstrip()
cooked = c.parse(raw).splitlines()
end_line = cooked[2].rstrip()
# this test is redundant, it's just here explicitly to catch
# the regression test so we don't forget what it looked like
self.assertNotEqual(end_line, "[clinic]*/[clinic]*/")
Expand Down Expand Up @@ -261,7 +260,7 @@ def _test_clinic(self, input, output):
c = clinic.Clinic(language, filename="file")
c.parsers['inert'] = InertParser(c)
c.parsers['copy'] = CopyParser(c)
computed, _ = c.parse(input)
computed = c.parse(input)
self.assertEqual(output, computed)

def test_clinic_1(self):
Expand Down