Skip to content

gh-104050: Annotate toplevel functions in clinic.py #106435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 16 commits into from
Jul 4, 2023
Merged

gh-104050: Annotate toplevel functions in clinic.py #106435

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
37082d4
Annotate strip_leading_and_trailing_blank_lines()
erlend-aasland Jul 4, 2023
8543ba4
Annotate normalize_snippet()
erlend-aasland Jul 4, 2023
3dcb343
Annotate declare_parser()
erlend-aasland Jul 4, 2023
a985dbb
Annotate wrap_declarations()
erlend-aasland Jul 4, 2023
bacaaaa
Annotate OverrideStdioWith()
erlend-aasland Jul 4, 2023
6dc1861
Annotate create_regex()
erlend-aasland Jul 4, 2023
977a153
Annotate add_c_converter()
erlend-aasland Jul 4, 2023
248ab08
Style
erlend-aasland Jul 4, 2023
7ed6108
Return type for write_file()
erlend-aasland Jul 4, 2023
7b89ffb
Annotate add_legacy_c_converter()
erlend-aasland Jul 4, 2023
0e2d3a0
Annotate correct_name_for_self()
erlend-aasland Jul 4, 2023
b5ae56f
Annotate required_type_for_self_for_parser()
erlend-aasland Jul 4, 2023
77ef693
Annotate eval_ast_expr()
erlend-aasland Jul 4, 2023
751d55c
Pull in main
erlend-aasland Jul 4, 2023
e9edfb8
Revert "Annotate OverrideStdioWith()"
erlend-aasland Jul 4, 2023
f184df7
Address review
erlend-aasland Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Annotate required_type_for_self_for_parser()
  • Loading branch information
@erlend-aasland
erlend-aasland committed Jul 4, 2023
commit b5ae56ff4147f90139dbd77e115dbcfee30ca0ba
4 changes: 3 additions & 1 deletion Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3922,7 +3922,9 @@ def correct_name_for_self(
return "PyTypeObject *", "type"
raise RuntimeError("Unhandled type of function f: " + repr(f.kind))

def required_type_for_self_for_parser(f):
def required_type_for_self_for_parser(
f: Function
) -> str | None:
type, _ = correct_name_for_self(f)
if f.kind in (METHOD_INIT, METHOD_NEW, STATIC_METHOD, CLASS_METHOD):
return type
Expand Down