Skip to content

gh-104584: Support most jumping instructions #106393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gvanrossum wants to merge 9 commits into from
Closed

gh-104584: Support most jumping instructions #106393

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d31d003
Hacky way to implement jump ops
gvanrossum Jul 2, 2023
b886ca6
Make JUMP_BACKWARD[_NO_INTERRUPT] viable
gvanrossum Jul 3, 2023
28b3951
Replace ENTER_EXECUTOR with the original in trace projection
gvanrossum Jul 3, 2023
0825696
Make POP_JUMP_IF_FALSE/TRUE conditionally jump
gvanrossum Jul 3, 2023
1df7b84
Implement JUMP_TO_TOP special uop
gvanrossum Jul 3, 2023
d6235ee
Cleanup some commented-out lines
gvanrossum Jul 4, 2023
6cd5719
Tweak FOR_ITER so it's viable
gvanrossum Jul 4, 2023
b33a1a2
Check room available for JUMP_TO_TOP
gvanrossum Jul 4, 2023
f5e18d8
A stray JUMP_BACKWARD also ends the trace
gvanrossum Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make POP_JUMP_IF_FALSE/TRUE conditionally jump 
This may destroy the symmetry or slow things down,
but (for now) it's needed so that the executor can
at least avoid bailing when the jump is not taken.
(The original code was doing a jump 0 in that case.)
  • Loading branch information
@gvanrossum
gvanrossum committed Jul 7, 2023
commit 0825696ffaac8ad46da80beea49c337c248d2c38
8 changes: 6 additions & 2 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2273,12 +2273,16 @@ dummy_func(

inst(POP_JUMP_IF_FALSE, (cond -- )) {
assert(PyBool_Check(cond));
JUMP_POP_DISPATCH(oparg * Py_IsFalse(cond), 1);
if (Py_IsFalse(cond)) {
JUMP_POP_DISPATCH(oparg, 1);
}
}

inst(POP_JUMP_IF_TRUE, (cond -- )) {
assert(PyBool_Check(cond));
JUMP_POP_DISPATCH(oparg * Py_IsTrue(cond), 1);
if (Py_IsTrue(cond)) {
JUMP_POP_DISPATCH(oparg, 1);
}
}

inst(POP_JUMP_IF_NOT_NONE, (value -- )) {
Expand Down
Loading