Skip to content

gh-106368: Increase Argument Clinic test coverage #106389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 2 commits into from
Jul 3, 2023
Merged

gh-106368: Increase Argument Clinic test coverage #106389

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e2b42f
gh-106368: Increase Argument Clinic test coverage
erlend-aasland Jul 3, 2023
90597cb
Update Lib/test/test_clinic.py
erlend-aasland Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-106368: Increase Argument Clinic test coverage 
Add:

- test_disallowed_gropuing__no_matching_bracket
- test_double_slash
  • Loading branch information
@erlend-aasland
erlend-aasland committed Jul 3, 2023
commit 2e2b42f3e079dbcaf580eef7ad72ea2265fc7352
24 changes: 24 additions & 0 deletions Lib/test/test_clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,18 @@ def test_disallowed_grouping__empty_group_on_right(self):
)
self.assertIn(msg, out)

def test_disallowed_gropuing__no_matching_bracket(self):
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated
out = self.parse_function_should_fail("""
module foo
foo.empty_group
param: int
]
group2: int
]
""")
msg = "Function empty_group has a ] without a matching [."
self.assertIn(msg, out)

def test_no_parameters(self):
function = self.parse_function("""
module foo
Expand Down Expand Up @@ -809,6 +821,18 @@ def test_single_slash(self):
)
self.assertIn(msg, out)

def test_double_slash(self):
out = self.parse_function_should_fail("""
module foo
foo.bar
a: int
/
b: int
/
""")
msg = "Function bar uses '/' more than once."
self.assertIn(msg, out)

def test_mix_star_and_slash(self):
out = self.parse_function_should_fail("""
module foo
Expand Down