Skip to content

gh-105983: add incognito mode to webbrowser module #106069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AmirNakhaeii wants to merge 6 commits into from
+31 −11
Closed

gh-105983: add incognito mode to webbrowser module #106069

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2b9a280
gh-105983: added incognito / private mode to webbrowser.py
AmirNakhaeii Jun 24, 2023
545784d
gh-105983: Fixed some logical errors
AmirNakhaeii Jun 24, 2023
f1a20fb
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 24, 2023
ae0602b
Merge branch 'python:main' into fix-issue-105983
AmirNakhaeii Jun 24, 2023
9312844
Merge branch 'main' into fix-issue-105983
AmirNakhaeii Jun 25, 2023
9e9811b
gh-105983: Fix incognito flag for edge browser
AmirNakhaeii Jun 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-105983: Fixed some logical errors
  • Loading branch information
@AmirNakhaeii
AmirNakhaeii committed Jun 24, 2023
commit 545784d94cbd9edf8067fd6d13c3b0e9454a225b
4 changes: 2 additions & 2 deletions Lib/webbrowser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,10 @@ def open(self, url, new=0, autoraise=True):
elif new == 1:
action = self.remote_action_newwin
elif new == 2:
if action := self.remote_action_newtab is None:
if (action := self.remote_action_newtab) is None:
action = self.remote_action_newwin
elif new == 3:
if action := self.remote_action_new_incognito_tab is None:
if (action := self.remote_action_new_incognito_tab) is None:
action = self.remote_action_newwin
else:
raise Error("Bad 'new' parameter to open(); " +
Expand Down