Skip to content

gh-106033: [docs] Improve C API GetItem & HasAttr notes. #106047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 15 commits into from
Jun 24, 2023
Merged

gh-106033: [docs] Improve C API GetItem & HasAttr notes. #106047

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f7083f2
[docs] Improve C API GetItem & HasAttr notes.
gpshead Jun 23, 2023
1e2d961
~object.
gpshead Jun 24, 2023
e4c34f2
more ~object.
gpshead Jun 24, 2023
8c15463
caution rather than note
gpshead Jun 24, 2023
1840e2b
caution rather than note
gpshead Jun 24, 2023
97ead38
~object
gpshead Jun 24, 2023
b83c9a2
~object
gpshead Jun 24, 2023
702ff45
~object
gpshead Jun 24, 2023
cfa054b
Update Doc/c-api/dict.rst
gpshead Jun 24, 2023
42beeb4
Update Doc/c-api/dict.rst
gpshead Jun 24, 2023
b24b019
Update Doc/c-api/dict.rst
gpshead Jun 24, 2023
302c387
Update Doc/c-api/dict.rst
gpshead Jun 24, 2023
badc027
Update Doc/c-api/object.rst
gpshead Jun 24, 2023
9aa6924
back to note
gpshead Jun 24, 2023
76d43ef
back to note
gpshead Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
caution rather than note 
ironically stands out less than note, but the bold caution: is still sufficient and better than what we had.  warning would stand out too much.

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
  • Loading branch information
@gpshead @CAM-Gerlach
gpshead and CAM-Gerlach authored Jun 24, 2023
commit 8c15463d313f5011326f087fda0679a048a9c63f
2 changes: 1 addition & 1 deletion Doc/c-api/object.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Object Protocol
is equivalent to the Python expression ``hasattr(o, attr_name)``. This function
always succeeds.

.. note::
.. caution::

Exceptions that occur when this calls :meth:`__getattr__` and
Comment thread
gpshead marked this conversation as resolved.
Outdated
:meth:`__getattribute__` methods are silently ignored.
Comment thread
gpshead marked this conversation as resolved.
Outdated
Expand Down