Skip to content

gh-106025: Fix incorrect usage of PyUnicode_CompareWithASCIIString in suggestions.c #106026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pablogsal wants to merge 1 commit into from
Closed

gh-106025: Fix incorrect usage of PyUnicode_CompareWithASCIIString in suggestions.c #106026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-106025: Fix incorrect usage of PyUnicode_CompareWithASCIIString in… 
… suggestions.c
  • Loading branch information
@pablogsal
pablogsal committed Jun 23, 2023
commit 39f72456c98a79f5afb6783ade7ca31a8ed230d6
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2023-06-23-15-03-41.gh-issue-106025.Ij5Bnn.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix incorrect usage of :c:func:`PyUnicode_CompareWithASCIIString` in
``suggestions.c``. Patch by Pablo Galindo
2 changes: 1 addition & 1 deletion Python/suggestions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ calculate_suggestions(PyObject *dir,
PyMem_Free(buffer);
return NULL;
}
if (PyUnicode_CompareWithASCIIString(name, item_str) == 0) {
if (PyUnicode_Compare(name, item) == 0) {
continue;
}
// No more than 1/3 of the involved characters should need changed.
Expand Down