Skip to content

GH-105848: Get rid of KW_NAMES #105849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brandtbucher wants to merge 13 commits into from
Closed

GH-105848: Get rid of KW_NAMES #105849

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
28adc90
Replace KW_NAMES with LOAD_CONST/PUSH_NULL
brandtbucher Jun 11, 2023
3aff105
Catch up with main
brandtbucher Jun 15, 2023
fc8176e
Bump magic number
brandtbucher Jun 16, 2023
dbda923
blurb add
brandtbucher Jun 16, 2023
8c414e5
Fix up the dis docs for CALL
brandtbucher Jun 16, 2023
abfd56a
Catch up with main
brandtbucher Jun 16, 2023
538633f
make patchcheck
brandtbucher Jun 16, 2023
f9a9aab
Fix doctests
brandtbucher Jun 16, 2023
a1640c7
Catch up with main
brandtbucher Jun 16, 2023
8da9d14
Use the low bit of CALL for kwnames
brandtbucher Jun 16, 2023
b022837
Fix blurb
brandtbucher Jun 16, 2023
408c615
fixup
brandtbucher Jun 16, 2023
47205b2
Remove bad blurb
brandtbucher Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make patchcheck
  • Loading branch information
@brandtbucher
brandtbucher committed Jun 16, 2023
commit 538633f2aef4b19af342cc6ce7a1c24203966ce7
2 changes: 1 addition & 1 deletion Doc/library/dis.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,7 +1387,7 @@ iterations of the loop.
returned by the callable object.

.. versionadded:: 3.11

.. versionchanged:: 3.12
Copy link
Copy Markdown
Member

@carljm carljm Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this is really a candidate for 3.12 backport?

Suggested change
.. versionchanged:: 3.12
.. versionchanged:: 3.13

Copy link
Copy Markdown
Member Author

@brandtbucher brandtbucher Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, typo.

Keyword names are now pushed to the stack instead of being indicated by
a preceding ``KW_NAMES`` instruction.
Expand Down