Skip to content

GH-105588: Add missing error checks to some obj2ast_* converters #105589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 4 commits into from
Jun 15, 2023
Merged

GH-105588: Add missing error checks to some obj2ast_* converters #105589

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0546055
Add failing regression tests
brandtbucher Jun 9, 2023
937af55
fixup
brandtbucher Jun 9, 2023
45e92fe
Add error checks after "product" node construction
brandtbucher Jun 9, 2023
f8036bd
blurb add
brandtbucher Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@brandtbucher
brandtbucher committed Jun 9, 2023
commit 937af55e75533685b0a2e88a85976ad5cf1fd0c6
4 changes: 2 additions & 2 deletions Lib/test/test_ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,8 +1131,8 @@ def test_none_checks(self) -> None:
(ast.comprehension, "target", "[spam for SPAM in spam]"),
(ast.comprehension, "iter", "[spam for spam in SPAM]"),
(ast.keyword, "value", "spam(**SPAM)"),
(ast.match_case, "pattern", "match spam:\n case SPAM: pass"),
(ast.withitem, "context_expr", "with SPAM: pass"),
(ast.match_case, "pattern", "match spam:\n case SPAM: spam"),
(ast.withitem, "context_expr", "with SPAM: spam"),
]
for node, attr, source in tests:
self.assert_none_check(node, attr, source)
Expand Down