Skip to content

[3.11] gh-104692: Include commoninstall as a prerequisite for bininstall (GH-104693) #105429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 2 commits into from
Jul 5, 2023
Merged

[3.11] gh-104692: Include commoninstall as a prerequisite for bininstall (GH-104693) #105429

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94d5d97
[3.11] gh-104692: Include commoninstall as a prerequisite for bininst…
jefferyto Jun 7, 2023
f211346
Merge branch '3.11' into backport-990cb36-3.11
erlend-aasland Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[3.11] gh-104692: Include commoninstall as a prerequisite for bininst… 
…all (GH-104693)

This ensures that `commoninstall` is completed before `bininstall` is
started when parallel builds are used (`make -j install`), and so the
`python3` symlink is only installed after all standard library modules
are installed.

Co-authored-by: Zachary Ware <zachary.ware@gmail.com>.
(cherry picked from commit 990cb36)

Co-authored-by: Jeffery To <jeffery.to@gmail.com>
  • Loading branch information
@jefferyto
jefferyto committed Jun 7, 2023
commit 94d5d97e6e267dc14ea236b4806c2e32678cf186
6 changes: 5 additions & 1 deletion Makefile.pre.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1839,7 +1839,11 @@ altbininstall: $(BUILDPYTHON) @FRAMEWORKPYTHONW@
$(DESTDIR)$(BINDIR)/python$(VERSION)$(EXE); \
fi

bininstall: altbininstall
# We depend on commoninstall here to make sure the installation is already usable
# before we possibly overwrite the global 'python3' symlink to avoid causing
# problems for anything else trying to run 'python3' while we install, particularly
# if we're installing in parallel with -j.
bininstall: commoninstall altbininstall
if test ! -d $(DESTDIR)$(LIBPC); then \
echo "Creating directory $(LIBPC)"; \
$(INSTALL) -d -m $(DIRMODE) $(DESTDIR)$(LIBPC); \
Expand Down
6 changes: 6 additions & 0 deletions Misc/NEWS.d/next/Build/2023-05-20-23-49-30.gh-issue-104692.s5UIu5.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Include ``commoninstall`` as a prerequisite for ``bininstall``

This ensures that ``commoninstall`` is completed before ``bininstall``
is started when parallel builds are used (``make -j install``), and so
the ``python3`` symlink is only installed after all standard library
modules are installed.