Skip to content

gh-98963: Restore the ability to have a dict-less property. #105262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 7 commits into from
Jun 5, 2023
+97 −13
Merged

gh-98963: Restore the ability to have a dict-less property. #105262

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93276d2
gh-98963: Restore the ability to have a dict-less property.
gpshead Jun 3, 2023
c6cdc7f
Fix ASAN issue, to many DECREFs :P
gpshead Jun 4, 2023
3ceab53
s/tabs/spaces/ (ugh editor configs)
gpshead Jun 4, 2023
95727f5
Restore all historical behaviors.
gpshead Jun 4, 2023
996e70b
Reword comments and NEWS.
gpshead Jun 4, 2023
517bd0d
restore the singular decref. (correctness)
gpshead Jun 4, 2023
0307832
DECREF before return, not always.
gpshead Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ASAN issue, to many DECREFs :P
  • Loading branch information
@gpshead
gpshead committed Jun 4, 2023
commit c6cdc7f87bf6258c36a0ff0c9f91a89a5d428da7
12 changes: 4 additions & 8 deletions Objects/descrobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1825,14 +1825,10 @@ property_init_impl(propertyobject *self, PyObject *fget, PyObject *fset,
// https://github.com/python/cpython/issues/98963#issuecomment-1574413319
// Python silently dropped this doc assignment through 3.11.
// We preserve that behavior for backwards compatibility.
if (prop_doc == Py_None) {
Py_DECREF(prop_doc);
return 0;
}
// If we ever want to deprecate this behavior, here is where to
// raise a DeprecationWarning; do not generate such noise when
// prop_doc is None.
Py_DECREF(prop_doc);
//
// If we ever want to deprecate this behavior, only raise a
// warning or error when proc_doc is not None so that
// property without a specific doc= still works.
return 0;
} else {
return -1;
Expand Down