Skip to content

gh-104310: Rename the New Function in importlib.util #105255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 7 commits into from
Jun 8, 2023
Merged

gh-104310: Rename the New Function in importlib.util #105255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f9521d
Fix the function doc string.
ericsnowcurrently Jun 2, 2023
04b36cf
Set the default for disable_check to False.
ericsnowcurrently Jun 2, 2023
d459def
Change the function name.
ericsnowcurrently Jun 2, 2023
27296cb
Add a NEWS entry.
ericsnowcurrently Jun 2, 2023
01fdb4d
Update Misc/NEWS.d/next/Library/2023-06-02-14-23-41.gh-issue-104310.U…
ericsnowcurrently Jun 2, 2023
bec03a2
Get rid of the default argument.
ericsnowcurrently Jun 2, 2023
760238e
Use a keyword-only parameter.
ericsnowcurrently Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use a keyword-only parameter.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Jun 8, 2023
commit 760238e0ac8de8b3895a3eac1f0e3e4d9995c25c
2 changes: 1 addition & 1 deletion Lib/importlib/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class _incompatible_extension_module_restrictions:
support for mulitple interpreters (or per-interpreter GIL).
"""

def __init__(self, disable_check):
def __init__(self, *, disable_check):
self.disable_check = bool(disable_check)

def __enter__(self):
Expand Down
24 changes: 12 additions & 12 deletions Lib/test/test_importlib/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,8 +678,8 @@ def run_with_shared_gil(self, script):
@unittest.skipIf(_testsinglephase is None, "test requires _testsinglephase module")
def test_single_phase_init_module(self):
script = textwrap.dedent('''
import importlib.util
with importlib.util._incompatible_extension_module_restrictions(True):
from importlib.util import _incompatible_extension_module_restrictions
with _incompatible_extension_module_restrictions(disable_check=True):
import _testsinglephase
''')
with self.subTest('check disabled, shared GIL'):
Expand All @@ -688,8 +688,8 @@ def test_single_phase_init_module(self):
self.run_with_own_gil(script)

script = textwrap.dedent(f'''
import importlib.util
with importlib.util._incompatible_extension_module_restrictions(False):
from importlib.util import _incompatible_extension_module_restrictions
with _incompatible_extension_module_restrictions(disable_check=False):
import _testsinglephase
''')
with self.subTest('check enabled, shared GIL'):
Expand All @@ -713,8 +713,8 @@ def test_incomplete_multi_phase_init_module(self):
''')

script = prescript + textwrap.dedent('''
import importlib.util
with importlib.util._incompatible_extension_module_restrictions(True):
from importlib.util import _incompatible_extension_module_restrictions
with _incompatible_extension_module_restrictions(disable_check=True):
module = module_from_spec(spec)
loader.exec_module(module)
''')
Expand All @@ -724,8 +724,8 @@ def test_incomplete_multi_phase_init_module(self):
self.run_with_own_gil(script)

script = prescript + textwrap.dedent('''
import importlib.util
with importlib.util._incompatible_extension_module_restrictions(False):
from importlib.util import _incompatible_extension_module_restrictions
with _incompatible_extension_module_restrictions(disable_check=False):
module = module_from_spec(spec)
loader.exec_module(module)
''')
Expand All @@ -738,8 +738,8 @@ def test_incomplete_multi_phase_init_module(self):
@unittest.skipIf(_testmultiphase is None, "test requires _testmultiphase module")
def test_complete_multi_phase_init_module(self):
script = textwrap.dedent('''
import importlib.util
with importlib.util._incompatible_extension_module_restrictions(True):
from importlib.util import _incompatible_extension_module_restrictions
with _incompatible_extension_module_restrictions(disable_check=True):
import _testmultiphase
''')
with self.subTest('check disabled, shared GIL'):
Expand All @@ -748,8 +748,8 @@ def test_complete_multi_phase_init_module(self):
self.run_with_own_gil(script)

script = textwrap.dedent(f'''
import importlib.util
with importlib.util._incompatible_extension_module_restrictions(False):
from importlib.util import _incompatible_extension_module_restrictions
with _incompatible_extension_module_restrictions(disable_check=False):
import _testmultiphase
''')
with self.subTest('check enabled, shared GIL'):
Expand Down