Skip to content

gh-105201: Add PyIter_NextItem to replace PyIter_Next which has an ambiguous output #105202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iritkatriel wants to merge 14 commits into from
Closed

gh-105201: Add PyIter_NextItem to replace PyIter_Next which has an ambiguous output #105202

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5e91524
gh-105201: Add PyIter_NextItem to replace PyIter_Next which has an am…
iritkatriel Jun 1, 2023
6987604
Merge branch 'main' into iter_nextitem
iritkatriel Jun 1, 2023
7905125
add new function to the stable ABI
iritkatriel Jun 1, 2023
cc29375
code review comments from Jella nd Erlend
iritkatriel Jun 1, 2023
9eb3a79
update doc
iritkatriel Jun 1, 2023
4dcb5d8
typo
iritkatriel Jun 1, 2023
5aaf37e
regen
iritkatriel Jun 1, 2023
edc54c8
make PyIter_NextItem return 0 for exhausted iterator and 1 when it pr…
iritkatriel Jun 1, 2023
8d93533
fix doc
iritkatriel Jun 1, 2023
02b64d4
Revert "fix doc"
iritkatriel Jun 1, 2023
1ee8618
Revert "make PyIter_NextItem return 0 for exhausted iterator and 1 wh…
iritkatriel Jun 1, 2023
028cef4
flip signature around
iritkatriel Jun 2, 2023
2c14604
if(err)
iritkatriel Jun 2, 2023
a6d58ab
Revert "if(err)"
iritkatriel Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix doc
  • Loading branch information
@iritkatriel
iritkatriel committed Jun 1, 2023
commit 8d93533a71c3f7286136ec87aa8960c3691f99ad
3 changes: 2 additions & 1 deletion Doc/c-api/iter.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ There are two functions specifically for working with iterators.
caller to check this).
If there are no remaining values, set ``*item`` to ``NULL``.

Return 0 on success and -1 on error.
Return 1 if an item was returned from the iterator, 0 if the iterator
is exhausted, and -1 on error.

To write a loop which iterates over an iterator, the C code should look
something like this::
Expand Down