Skip to content

gh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred #105185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 3 commits into from
Jun 2, 2023
+8 −0
Merged

gh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred #105185

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
212c72e
gh-105184: document that marshal functions can fail and need to be ch…
iritkatriel Jun 1, 2023
df93125
add comment
iritkatriel Jun 1, 2023
a2c72fb
Apply suggestions from code review
iritkatriel Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comment
  • Loading branch information
@iritkatriel
iritkatriel committed Jun 1, 2023
commit df93125004f87736b46d58dad61671cc4bb9a063
4 changes: 4 additions & 0 deletions Python/marshal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,10 @@ w_clear_refs(WFILE *wf)
}

/* version currently has no effect for writing ints. */
/* Note that while the documentation states that this function
* can error, currently it never does. Setting an exception in
* this function should be regarded as an API-breaking change.
*/
void
PyMarshal_WriteLongToFile(long x, FILE *fp, int version)
{
Expand Down