Skip to content

gh-105144: Runtime-checkable protocols: move all 'sanity checks' to _ProtocolMeta.__subclasscheck__ #105152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 4 commits into from
May 31, 2023
Merged

gh-105144: Runtime-checkable protocols: move all 'sanity checks' to _ProtocolMeta.__subclasscheck__ #105152

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
937e8dc
Runtime-checkable protocols: move all 'sanity checks' to `_ProtocolMe…
AlexWaygood May 31, 2023
3b56274
Simplify
AlexWaygood May 31, 2023
0b13ae0
Explicitly clear the cache
AlexWaygood May 31, 2023
3ba9647
off-by-one error in a comment!
AlexWaygood May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Explicitly clear the cache
  • Loading branch information
@AlexWaygood
AlexWaygood committed May 31, 2023
commit 0b13ae02ac75e3d3cacebd6176c3bd194517b366
6 changes: 6 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3706,6 +3706,9 @@ def __init__(self):
Foo() # Previously triggered RecursionError

def test_interaction_with_isinstance_checks_on_superclasses_with_ABCMeta(self):
Comment thread
JelleZijlstra marked this conversation as resolved.
# Ensure the cache is empty, or this test won't work correctly
collections.abc.Sized._abc_registry_clear()

class Foo(collections.abc.Sized, Protocol): pass

# gh-105144: this previously raised TypeError
Expand All @@ -3714,6 +3717,9 @@ class Foo(collections.abc.Sized, Protocol): pass
self.assertNotIsInstance(1, collections.abc.Sized)

def test_interaction_with_isinstance_checks_on_superclasses_with_ABCMeta_2(self):
# Ensure the cache is empty, or this test won't work correctly
collections.abc.Sized._abc_registry_clear()

class Foo(typing.Sized, Protocol): pass

# gh-105144: this previously raised TypeError
Expand Down