Skip to content

gh-102251: Fix reference leak in _testsinglephase initialization #105082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 2 commits into from
May 30, 2023
+3 −1
Merged

gh-102251: Fix reference leak in _testsinglephase initialization #105082

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd70c5
add missing decref in testsinglephase
sunmy2019 May 30, 2023
587533c
Use idiomatic C code
erlend-aasland May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add missing decref in testsinglephase
  • Loading branch information
@sunmy2019
sunmy2019 committed May 30, 2023
commit dfd70c5c93a0bc4f3a8021d9ba794bc4951a0491
4 changes: 3 additions & 1 deletion Modules/_testsinglephase.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ init_module(PyObject *module, module_state *state)
if (initialized == NULL) {
return -1;
}
if (PyModule_AddObjectRef(module, "_module_initialized", initialized) != 0) {
int rc = PyModule_AddObjectRef(module, "_module_initialized", initialized);
Py_DECREF(initialized);
if (rc != 0) {
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated
return -1;
}

Expand Down