Skip to content

GH-104947: Make pathlib.PureWindowsPath comparisons consistent across platforms #104948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 3 commits into from
May 26, 2023
Merged

GH-104947: Make pathlib.PureWindowsPath comparisons consistent across platforms #104948

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
501c06d
Add failing test.
barneygale May 25, 2023
256e1ee
GH-104947: Make pathlib.PureWindowsPath comparisons consistent across…
barneygale May 25, 2023
9327012
mention this matches 3.11 behavior in the news entry.
gpshead May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GH-104947: Make pathlib.PureWindowsPath comparisons consistent across… 
… OSs

Use `str.lower()` rather than `ntpath.normcase()` to normalize case of
Windows paths. This restores behaviour from Python 3.11.
  • Loading branch information
@barneygale
barneygale committed May 25, 2023
commit 256e1ee4712c22ad9c52d0cba3eb7f3d93952974
5 changes: 4 additions & 1 deletion Lib/pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,10 @@ def _str_normcase(self):
try:
return self._str_normcase_cached
except AttributeError:
self._str_normcase_cached = self._flavour.normcase(str(self))
if _is_case_sensitive(self._flavour):
self._str_normcase_cached = str(self)
else:
self._str_normcase_cached = str(self).lower()
return self._str_normcase_cached

@property
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2023-05-25-22-54-20.gh-issue-104947.hi6TUr.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Make comparisons between :class:`pathlib.PureWindowsPath` objects consistent
across Windows and Posix.