Skip to content

gh-104935: typing: Fix interactions between @runtime_checkable and Generic #104939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 5 commits into from
May 25, 2023
Merged

gh-104935: typing: Fix interactions between @runtime_checkable and Generic #104939

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c3c428
gh-104935: Add back typing.Generic._is_protocol
JelleZijlstra May 25, 2023
a61816b
Improve tests
JelleZijlstra May 25, 2023
19bbcb0
Update Lib/test/test_typing.py
JelleZijlstra May 25, 2023
f299fbd
Better approach
JelleZijlstra May 25, 2023
0859dcd
Update news
JelleZijlstra May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/test/test_typing.py 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
  • Loading branch information
@JelleZijlstra @AlexWaygood
JelleZijlstra and AlexWaygood authored May 25, 2023
commit 19bbcb05fbee4049058e149ba7913407b14b89c7
2 changes: 2 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2500,10 +2500,12 @@ def test_pep695_generics_can_be_runtime_checkable(self):
@runtime_checkable
class HasX(Protocol):
x: int

class Bar[T]:
x: T
def __init__(self, x):
self.x = x

class Capybara[T]:
Comment thread
JelleZijlstra marked this conversation as resolved.
y: str
def __init__(self, y):
Expand Down