bpo-35220: delete "how do I emulate os.kill" section in Windows FAQ#10487
Merged
Conversation
That section is a tip on how to kill process on Windows for Python prior to 2.7 and 3.2. 3.1 end of support was April 2012 and 2.6 was October 2013, so that hasn't been need for supported versions of Python for more than 5 years. Beside not being needed anymore for a long time, when I read it with the eyes of a Python profane, it makes Python looks bad, like a language from the parts with warts you need to circumvent. Let's delete that :)
JulienPalard
approved these changes
Nov 12, 2018
Member
JulienPalard
left a comment
There was a problem hiding this comment.
LGTM, anyway this block will remain on those old documentations so it will still be accessible, as long as people are reading the right documentation version.
Contributor
Author
|
@JulienPalard could we also backport to 3.7, 3.6 and 3.5 since, as stated in the documentation, it's unneeded since python 3.2 ? |
JulienPalard
pushed a commit
to JulienPalard/cpython
that referenced
this pull request
Nov 28, 2018
…ythonGH-10487) That section is a tip on how to kill process on Windows for Python prior to 2.7 and 3.2. 3.1 end of support was April 2012 and 2.6 was October 2013, so that hasn't been need for supported versions of Python for more than 5 years. Beside not being needed anymore for a long time, when I read it with the eyes of a Python profane, it makes Python looks bad, like a language from the parts with warts you need to circumvent. Let's delete that :). (cherry picked from commit a1c4001) Co-authored-by: Mathieu Dupuy <deronnax@users.noreply.github.com>
JulienPalard
pushed a commit
to JulienPalard/cpython
that referenced
this pull request
Nov 28, 2018
…ythonGH-10487) That section is a tip on how to kill process on Windows for Python prior to 2.7 and 3.2. 3.1 end of support was April 2012 and 2.6 was October 2013, so that hasn't been need for supported versions of Python for more than 5 years. Beside not being needed anymore for a long time, when I read it with the eyes of a Python profane, it makes Python looks bad, like a language from the parts with warts you need to circumvent. Let's delete that :). (cherry picked from commit a1c4001) Co-authored-by: Mathieu Dupuy <deronnax@users.noreply.github.com>
miss-islington
pushed a commit
that referenced
this pull request
Nov 28, 2018
JulienPalard
added a commit
that referenced
this pull request
Nov 28, 2018
…H-10487) (GH-10768) That section is a tip on how to kill process on Windows for Python prior to 2.7 and 3.2. 3.1 end of support was April 2012 and 2.6 was October 2013, so that hasn't been need for supported versions of Python for more than 5 years. Beside not being needed anymore for a long time, when I read it with the eyes of a Python profane, it makes Python looks bad, like a language from the parts with warts you need to circumvent. Let's delete that :). (cherry picked from commit a1c4001) Co-authored-by: Mathieu Dupuy <deronnax@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That section is a tip on how to kill process on Windows for Python prior to 2.7 and 3.2.
3.1 end of support was April 2012 and 2.6 was October 2013, so that hasn't been needed for supported versions of Python for more than 5 years. Beside not being needed anymore for a long time, when I read it with the eyes of a Python profane, it makes Python looks bad, like a language from the past with warts you need to circumvent.
Let's delete that :)