Skip to content

gh-104690 Disallow thread creation and fork at interpreter finalization #104826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 16 commits into from
Jun 4, 2023
Merged

gh-104690 Disallow thread creation and fork at interpreter finalization #104826

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
15ecad5
Disallow thread creation and fork at interpreter finalization
chgnrdv May 24, 2023
72095f3
improved error messages
chgnrdv May 24, 2023
77443a0
added tests, changed test_threading.ThreadTests.test_fork_at_exit to …
chgnrdv May 24, 2023
3134fbe
📜🤖 Added by blurb_it.
blurb-it[bot] May 24, 2023
530f785
Merge branch 'main' into disallow-thread-creation-and-fork-at-interp-…
chgnrdv May 24, 2023
d26b8db
Merge branch 'main' into disallow-thread-creation-and-fork-at-interp-…
chgnrdv May 26, 2023
1c51471
Merge branch 'disallow-thread-creation-and-fork-at-interp-exit' of gi…
chgnrdv May 26, 2023
bbc8ca4
Suggested changes:
chgnrdv May 26, 2023
bcbcb75
fixed test case in test_subprocess
chgnrdv May 26, 2023
0926f6f
Reword and clarify the NEWS entry.
gpshead May 26, 2023
ec66e17
Merge branch 'main' into disallow-thread-creation-and-fork-at-interp-…
gpshead May 26, 2023
cda40a9
Merge branch 'main' into disallow-thread-creation-and-fork-at-interp-…
chgnrdv May 26, 2023
64e7e47
Merge branch 'disallow-thread-creation-and-fork-at-interp-exit' of gi…
chgnrdv May 26, 2023
9d0a750
mentioned new behaviour and added warning about old one in atexit docs
chgnrdv May 26, 2023
deb9204
Cleanup atexit.rst wording.
gpshead Jun 3, 2023
be7de06
Merge branch 'main' into disallow-thread-creation-and-fork-at-interp-…
gpshead Jun 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed test case in test_subprocess
  • Loading branch information
@chgnrdv
chgnrdv committed May 26, 2023
commit bcbcb75ea595dee5cddde23b828506bcb4fcbdcd
9 changes: 6 additions & 3 deletions Lib/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3330,20 +3330,23 @@ def test_communicate_repeated_call_after_stdout_close(self):
except subprocess.TimeoutExpired:
pass

def test_create_child_process_at_exit(self):
def test_preexec_at_exit(self):
code = f"""if 1:
import atexit
import subprocess

def dummy():
pass

def exit_handler():
subprocess.Popen({ZERO_RETURN_CMD})
subprocess.Popen({ZERO_RETURN_CMD}, preexec_fn=dummy)
print("shouldn't be printed")

atexit.register(exit_handler)
"""
_, out, err = assert_python_ok("-c", code)
self.assertEqual(out, b'')
self.assertIn(b"can't create child process at interpreter shutdown", err)
self.assertIn(b"preexec_fn not supported at interpreter shutdown", err)


@unittest.skipUnless(mswindows, "Windows specific tests")
Expand Down