bpo-30021: Add examples for re.escape().#1048
Merged
serhiy-storchaka merged 3 commits intoApr 13, 2017
Merged
Conversation
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @tiran and @ezio-melotti to be potential reviewers. |
berkerpeksag
approved these changes
Apr 13, 2017
Member
berkerpeksag
left a comment
There was a problem hiding this comment.
LGTM, I'd probably use an f-string in the second example, but that would make backporting it to 2.7 and 3.5 harder.
Member
Author
|
It is hard to use f-strings with regular expressions since |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Apr 13, 2017
And fix the parameter name. (cherry picked from commit 8fc7bc2)
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Apr 13, 2017
And fix the parameter name. (cherry picked from commit 8fc7bc2)
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Apr 13, 2017
And fix the parameter name. (cherry picked from commit 8fc7bc2)
serhiy-storchaka
added a commit
that referenced
this pull request
Apr 13, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
Apr 13, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
Apr 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.