Skip to content

[3.12] gh-87891: Add ABI check to CI #104793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yhg1s merged 5 commits into from
May 23, 2023
Merged

[3.12] gh-87891: Add ABI check to CI #104793

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1aeeebd
[3.12] Add CI step to check changes in the exported ABI (#92442)
pablogsal May 8, 2022
9d9a5d8
Remove ABI dump from gitignore
encukou May 23, 2023
0834f18
Add ABI dump generated in a ubuntu:22.04 comtainer
encukou May 23, 2023
51a0e66
Use Ubuntu 22.04 (latest LTS & version in the devguide)
encukou May 23, 2023
a5d9ec0
Version updates & typo fixes
encukou May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,36 @@ jobs:
echo "run_hypothesis=true" >> $GITHUB_OUTPUT
fi

check_abi:
name: 'Check if the ABI has changed'
Comment thread
Yhg1s marked this conversation as resolved.
runs-on: ubuntu-20.04
Comment thread
encukou marked this conversation as resolved.
Outdated
needs: check_source
if: needs.check_source.outputs.run_tests == 'true'
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
Comment thread
encukou marked this conversation as resolved.
Outdated
- name: Install Dependencies
Comment thread
encukou marked this conversation as resolved.
Outdated
run: |
sudo ./.github/workflows/posix-deps-apt.sh
sudo apt-get install -yq abigail-tools
- name: Build CPython
env:
CFLAGS: -g3 -O0
run: |
# Build Python with the libpython dynamic library
./configure --enable-shared
make -j4
- name: Check for changes in the ABI
run: |
if ! make check-abidump; then
echo "Generated ABI file is not up to date."
echo "Please, add the release manager of this branch as a reviewer of this PR."
Comment thread
encukou marked this conversation as resolved.
Outdated
echo ""
echo "To learn more about this check, please visit: https://devguide.python.org/setup/?highlight=abi#regenerate-the-abi-dump"
Comment thread
encukou marked this conversation as resolved.
Outdated
echo ""
exit 1
fi

check_generated_files:
name: 'Check if generated files are up to date'
runs-on: ubuntu-latest
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,3 @@ Python/frozen_modules/MANIFEST
# Ignore ./python binary on Unix but still look into ./Python/ directory.
/python
!/Python/

# main branch only: ABI files are not checked/maintained
Doc/data/python*.abi
Loading