Skip to content

gh-86275: improve Hypothesis configuration for CI and local runs #104468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 4 commits into from
May 21, 2023
Merged

gh-86275: improve Hypothesis configuration for CI and local runs #104468

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f08da66
gh-86275: Don't fail PBTs for running slowly
Zac-HD May 14, 2023
59a2793
gh-86275: Cache Hypothesis' db in CI
Zac-HD May 14, 2023
2d3b811
gh-86275: use pull-through cache
Zac-HD May 14, 2023
ccbb010
Make restore-keys a string
Zac-HD May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make restore-keys a string
  • Loading branch information
@Zac-HD
Zac-HD committed May 20, 2023
commit ccbb010c8bc2fd44802063b0884337f387105e34
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ jobs:
with:
path: ./hypothesis
key: hypothesis-database-${{ github.head_ref || github.run_id }}
restore-keys:
restore-keys: |
- hypothesis-database-
Copy link
Copy Markdown
Member

@webknjaz webknjaz Jul 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zac-HD did you mean to keep that leading hyphen?

Copy link
Copy Markdown
Member

@webknjaz webknjaz Jul 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it look up the '- hypothesis-database-' prefix, and I'm pretty sure you wanted 'hypothesis-database-':

Cache not found for input keys: hypothesis-database-9927179210, - hypothesis-database-

(https://github.com/python/cpython/actions/runs/9927179210/job/27421821417#step:21:24)

Copy link
Copy Markdown
Member

@webknjaz webknjaz Jul 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zac-HD here's the fix: #121756

- name: "Run tests"
working-directory: ${{ env.CPYTHON_BUILDDIR }}
Expand Down