Skip to content

gh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic #104355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 6 commits into from
May 10, 2023
Merged

gh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic #104355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98dd91b
gh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic
erlend-aasland May 10, 2023
fc14019
Wrap docstrings
erlend-aasland May 10, 2023
34c3e99
Add missing *args
erlend-aasland May 10, 2023
7c785b3
..but not detach()
erlend-aasland May 10, 2023
28fc57e
Use consistent mood, since we're touching this anyways
erlend-aasland May 10, 2023
940db40
Address docstring review
erlend-aasland May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
..but not detach()
  • Loading branch information
@erlend-aasland
erlend-aasland committed May 10, 2023
commit 7c785b34a66ef4600970dedbdf0b00798b142069
6 changes: 2 additions & 4 deletions Modules/_io/bufferedio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ _io._BufferedIOBase.detach

cls: defining_class
/
*args: object

Disconnect this buffer from its underlying raw stream and return it.

Expand All @@ -126,9 +125,8 @@ state.
[clinic start generated code]*/

static PyObject *
_io__BufferedIOBase_detach_impl(PyObject *self, PyTypeObject *cls,
PyObject *args)
/*[clinic end generated code: output=f713c93ded3dd685 input=fb1ce27699f480eb]*/
_io__BufferedIOBase_detach_impl(PyObject *self, PyTypeObject *cls)
/*[clinic end generated code: output=b87b135d67cd4448 input=0b61a7b4357c1ea7]*/
{
_PyIO_State *state = IO_STATE();
return bufferediobase_unsupported(state, "detach");
Expand Down
37 changes: 7 additions & 30 deletions Modules/_io/clinic/bufferedio.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.