Skip to content

[3.10] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953) #104327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
encukou wants to merge 7 commits into from
Closed

[3.10] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953) #104327

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
52dd746
Implement PEP 706 – Filter for tarfile.extractall
encukou Jan 31, 2023
10a05d8
Adjust the docs for 3.10.12
encukou Apr 25, 2023
b2f7a44
Remove the DeprecationWarning
encukou Apr 25, 2023
688286c
Remove new __all__ entries
encukou Apr 25, 2023
ae62b3a
gh-102950: Adjust tarfile filter tests for systems that don't set the…
encukou Apr 25, 2023
abb0e84
Fix version numbers in documentation.
mcepl May 4, 2023
62602ff
Skip chmod checking on Windows
encukou May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Skip chmod checking on Windows
  • Loading branch information
@encukou
encukou committed May 9, 2023
commit 62602ff60ac0302a0d57cfde5da9c11b0aef9b0f
7 changes: 6 additions & 1 deletion Lib/test/test_tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3284,9 +3284,14 @@ def expect_file(self, name, type=None, symlink_to=None, mode=None):
path = pathlib.Path(os.path.normpath(self.destdir / name))
self.assertIn(path, self.expected_paths)
self.expected_paths.remove(path)
if mode is not None:

# When checking mode, ignore Windows (which can only set user read and
# user write bits). Newer versions of Python use `os_helper.can_chmod()`
# instead of hardcoding Windows.
if mode is not None and sys.platform != 'win32':
got = stat.filemode(stat.S_IMODE(path.stat().st_mode))
self.assertEqual(got, mode)

if type is None and isinstance(name, str) and name.endswith('/'):
type = tarfile.DIRTYPE
if symlink_to is not None:
Expand Down