Skip to content

[3.12] gh-104271: Fix auto() fallback in case of mixed type Enum #104279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanfurman merged 3 commits into from
May 23, 2023
+5 −2
Merged

[3.12] gh-104271: Fix auto() fallback in case of mixed type Enum #104279

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09bfba4
gh-104271: Fix auto() fallback in case of mixed type Enum
itamaro May 7, 2023
0f0de17
Merge branch '3.12' into gh-104271
ethanfurman May 23, 2023
fa2ea05
Merge branch '3.12' into gh-104271
ethanfurman May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-104271: Fix auto() fallback in case of mixed type Enum
  • Loading branch information
@itamaro
itamaro committed May 7, 2023
commit 09bfba4785d031472c181f19aa335c8fcd034ad1
2 changes: 1 addition & 1 deletion Lib/enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,7 +1185,7 @@ def _generate_next_value_(name, start, count, last_values):
DeprecationWarning,
stacklevel=3,
)
for v in last_values:
for v in reversed(last_values):
try:
return v + 1
except TypeError:
Expand Down
5 changes: 4 additions & 1 deletion Lib/test/test_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4254,11 +4254,14 @@ class Color(Enum):
red = 'red'
blue = 2
green = auto()
yellow = auto()

self.assertEqual(list(Color), [Color.red, Color.blue, Color.green])
self.assertEqual(list(Color),
[Color.red, Color.blue, Color.green, Color.yellow])
self.assertEqual(Color.red.value, 'red')
self.assertEqual(Color.blue.value, 2)
self.assertEqual(Color.green.value, 3)
self.assertEqual(Color.yellow.value, 4)

@unittest.skipIf(
python_version < (3, 13),
Expand Down