Skip to content

GH-104102: Optimize pathlib.Path.glob() handling of ../ pattern segments #104103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 4 commits into from
May 2, 2023
Merged

GH-104102: Optimize pathlib.Path.glob() handling of ../ pattern segments #104103

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f268157
Optimize `pathlib.Path.glob()` handling of `../` pattern segments
barneygale May 2, 2023
581e8c5
Merge branch 'main' into gh-104102-optimize-glob-parent
barneygale May 2, 2023
e35153f
Fix argument name
barneygale May 2, 2023
6ab6f0f
Expand tests
barneygale May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Expand tests
  • Loading branch information
@barneygale
barneygale committed May 2, 2023
commit 6ab6f0f34bc81ef8d720f627d980e9920f5d2cb4
5 changes: 5 additions & 0 deletions Lib/test/test_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1892,8 +1892,13 @@ def test_glob_dotdot(self):
P = self.cls
p = P(BASE)
self.assertEqual(set(p.glob("..")), { P(BASE, "..") })
self.assertEqual(set(p.glob("../..")), { P(BASE, "..", "..") })
self.assertEqual(set(p.glob("dirA/..")), { P(BASE, "dirA", "..") })
self.assertEqual(set(p.glob("dirA/../file*")), { P(BASE, "dirA/../fileA") })
self.assertEqual(set(p.glob("dirA/../file*/..")), set())
self.assertEqual(set(p.glob("../xyzzy")), set())
self.assertEqual(set(p.glob("xyzzy/..")), set())
self.assertEqual(set(p.glob("/".join([".."] * 50))), { P(BASE, *[".."] * 50)})

@os_helper.skip_unless_symlink
def test_glob_permissions(self):
Expand Down