Skip to content

gh-103956: fix trace output in case of missing source line #103958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 8 commits into from
May 9, 2024
Merged

gh-103956: fix trace output in case of missing source line #103958

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
589f22f
Fix `Trace.localtrace_trace*` output in case of missing source line
chgnrdv Apr 27, 2023
83bc542
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 28, 2023
e840e5f
refactor
chgnrdv Feb 10, 2024
ea443aa
Merge branch 'main' into trace-fix-lacking-newlines
chgnrdv Feb 10, 2024
095a204
Merge branch 'main' into trace-fix-lacking-newlines
chgnrdv Feb 10, 2024
f9fffa8
added test
chgnrdv Feb 10, 2024
7e452a8
Merge branch 'trace-fix-lacking-newlines' of github.com:chgnrdv/cpyth…
chgnrdv Feb 10, 2024
505f4e0
Merge branch 'main' into trace-fix-lacking-newlines
chgnrdv May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added test
  • Loading branch information
@chgnrdv
chgnrdv committed Feb 10, 2024
commit f9fffa8c2471f215b8178f7eea5d40178336df05
25 changes: 25 additions & 0 deletions Lib/test/test_trace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from test.support.script_helper import assert_python_ok, assert_python_failure
import textwrap
import unittest
from types import FunctionType

import trace
from trace import Trace
Expand Down Expand Up @@ -559,5 +560,29 @@ def test_run_as_module(self):
assert_python_failure('-m', 'trace', '-l', '--module', 'not_a_module_zzz')


class TestTrace(unittest.TestCase):
def setUp(self):
self.addCleanup(sys.settrace, sys.gettrace())
self.tracer = Trace(count=0, trace=1)
self.filemod = my_file_and_modname()

def test_no_source_file(self):
filename = "<unknown>"
co = traced_func_linear.__code__
co = co.replace(co_filename=filename)
f = FunctionType(co, globals())

with captured_stdout() as out:
self.tracer.runfunc(f, 2, 3)

out = out.getvalue().splitlines()
firstlineno = get_firstlineno(f)
self.assertIn(f" --- modulename: {self.filemod[1]}, funcname: {f.__code__.co_name}", out[0])
self.assertIn(f"{filename}({firstlineno + 1})", out[1])
self.assertIn(f"{filename}({firstlineno + 2})", out[2])
self.assertIn(f"{filename}({firstlineno + 3})", out[3])
self.assertIn(f"{filename}({firstlineno + 4})", out[4])


if __name__ == '__main__':
unittest.main()