Skip to content

gh-103636: issue warning for deprecated calendar constants #103833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 21 commits into from
Apr 29, 2023
Merged

gh-103636: issue warning for deprecated calendar constants #103833

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
175dadf
gh-103636: raise warning for January and February attribute
Agent-Hellboy Apr 25, 2023
97436c8
add test
Agent-Hellboy Apr 26, 2023
e6f2a2f
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 26, 2023
5a4d0a7
update docs for depration warning and new additions
Agent-Hellboy Apr 26, 2023
ddcdc43
dedent line in calendar test
Agent-Hellboy Apr 26, 2023
794dddc
fix doc
Agent-Hellboy Apr 26, 2023
717cea8
fix doc
Agent-Hellboy Apr 26, 2023
b2c13e8
fix doc
Agent-Hellboy Apr 26, 2023
029844f
fix doc
Agent-Hellboy Apr 26, 2023
0c52a19
fix doc
Agent-Hellboy Apr 26, 2023
ac783cf
fix spacing
merwok Apr 26, 2023
a18a064
Merge branch 'main' into raise-warning-in-calendar-mod
merwok Apr 26, 2023
e002e10
fix grametical mistake
Agent-Hellboy Apr 27, 2023
57ee1f9
Apply suggestions from code review
Agent-Hellboy Apr 27, 2023
cdcb22a
arrange module in alphabetical order in whats new
Agent-Hellboy Apr 27, 2023
49079d1
Update Doc/whatsnew/3.12.rst
Agent-Hellboy Apr 27, 2023
db53e78
Update Doc/whatsnew/3.12.rst
Agent-Hellboy Apr 27, 2023
9c289c5
fix doc
Agent-Hellboy Apr 27, 2023
4b497b2
Merge branch 'main' into raise-warning-in-calendar-mod
merwok Apr 27, 2023
7ec1945
Update Doc/library/calendar.rst
Agent-Hellboy Apr 28, 2023
7628f11
Update Doc/library/calendar.rst
Agent-Hellboy Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-103636: raise warning for January and February attribute
  • Loading branch information
@Agent-Hellboy
Agent-Hellboy committed Apr 25, 2023
commit 175dadf4e8f23ec026e676be73fddee69a3b181a
14 changes: 14 additions & 0 deletions Lib/calendar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from enum import IntEnum, global_enum
import locale as _locale
from itertools import repeat
import warnings

__all__ = ["IllegalMonthError", "IllegalWeekdayError", "setfirstweekday",
"firstweekday", "isleap", "leapdays", "weekday", "monthrange",
Expand Down Expand Up @@ -41,6 +42,18 @@ def __str__(self):
return "bad weekday number %r; must be 0 (Monday) to 6 (Sunday)" % self.weekday


def __getattr__(name):
if name in ['January','February']:
Comment thread
Agent-Hellboy marked this conversation as resolved.
Outdated
warnings.warn(f"The '{name}' attribute is going to be deprecated use '{name.upper()}' instead",
Comment thread
Agent-Hellboy marked this conversation as resolved.
Outdated
DeprecationWarning,
stacklevel=2)
Comment thread
merwok marked this conversation as resolved.
Outdated
if name == 'January':
return JANUARY
else:
return FEBRUARY
Comment thread
Agent-Hellboy marked this conversation as resolved.
Outdated

raise AttributeError(f"module {__name__} has no attribute {name}")
Comment thread
Agent-Hellboy marked this conversation as resolved.
Outdated

# Constants for months
@global_enum
class Month(IntEnum):
Expand Down Expand Up @@ -71,6 +84,7 @@ class Day(IntEnum):


Comment thread
merwok marked this conversation as resolved.


Comment thread
Agent-Hellboy marked this conversation as resolved.
Outdated
# Number of days per month (except for February in leap years)
mdays = [0, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31]

Expand Down