Skip to content

gh-103822: change return value to enum for day and month APIs #103827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanfurman merged 3 commits into from
May 2, 2023
Merged

gh-103822: change return value to enum for day and month APIs #103827

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a14dd87
gh-103822: change return value to enums for days and month API in
Agent-Hellboy Apr 25, 2023
ced5653
remove _get_enum_attribute
Agent-Hellboy May 2, 2023
950e31f
📜🤖 Added by blurb_it.
blurb-it[bot] May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove _get_enum_attribute
  • Loading branch information
@Agent-Hellboy
Agent-Hellboy committed May 2, 2023
commit ced565316b7797cd050838a4b1eb099943b74094
10 changes: 1 addition & 9 deletions Lib/calendar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,6 @@ class Day(IntEnum):
SUNDAY = 6


def _get_enum_attribute(value, enum_type):
"""Returns the value of the specified attribute of a Day or Month Enum object based on its integer value."""
if enum_type == "day":
return Day(value)
else:
return Month(value)


# Number of days per month (except for February in leap years)
mdays = [0, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31]

Expand Down Expand Up @@ -150,7 +142,7 @@ def weekday(year, month, day):
"""Return weekday (0-6 ~ Mon-Sun) for year, month (1-12), day (1-31)."""
if not datetime.MINYEAR <= year <= datetime.MAXYEAR:
year = 2000 + year % 400
return _get_enum_attribute(datetime.date(year, month, day).weekday(),'day')
return Day(datetime.date(year, month, day).weekday())


def monthrange(year, month):
Expand Down