Skip to content

[3.11] gh-91687: modernize dataclass example typing (GH-103773) #103774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 3 commits into from
Apr 25, 2023
+1 −1
Merged

[3.11] gh-91687: modernize dataclass example typing (GH-103773) #103774

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f56f910
gh-91687: modernize dataclass example typing (GH-103773)
alago1 Apr 24, 2023
b52528e
Merge branch '3.11' into backport-7ef614c-3.11
ambv Apr 25, 2023
cd20610
Merge branch '3.11' into backport-7ef614c-3.11
ambv Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-91687: modernize dataclass example typing (GH-103773) 
modernize dataclass example typing `list` rather than `List` and comment as to that line being the alluded too error.
(cherry picked from commit 7ef614c)

Co-authored-by: Allan Lago <35788148+alago1@users.noreply.github.com>
  • Loading branch information
@alago1 @miss-islington
alago1 authored and miss-islington committed Apr 24, 2023
commit f56f910d5dd512ec7a2a4d50b90068ce11b05fc7
2 changes: 1 addition & 1 deletion Doc/library/dataclasses.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,7 @@ Using dataclasses, *if* this code was valid::

@dataclass
class D:
x: List = []
x: list = [] # This code raises ValueError
def add(self, element):
self.x += element

Expand Down